Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to exclude ProjectGenerationConfigurations #1584

Closed
wants to merge 3 commits into from
Closed

Add ability to exclude ProjectGenerationConfigurations #1584

wants to merge 3 commits into from

Conversation

zambrovski
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 14, 2024
@mhalbritter mhalbritter self-assigned this Nov 19, 2024
@mhalbritter mhalbritter changed the title Implementation for ProjectGenerationConfiguration exclusion Add ability to exclude ProjectGenerationConfigurations Nov 19, 2024
@mhalbritter mhalbritter added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 19, 2024
mhalbritter pushed a commit that referenced this pull request Nov 19, 2024
@zambrovski @mhalbritter
Add ability to exclude ProjectGenerationConfiguration
2b83654 
See gh-1584
mhalbritter added a commit that referenced this pull request Nov 19, 2024
@mhalbritter
Polish "Add ability to exclude ProjectGenerationConfiguration"
2945eb1 
See gh-1584
@mhalbritter
Copy link
Contributor

mhalbritter commented Nov 19, 2024 •
edited
Loading

Thanks @zambrovski !

I've flipped the logic around: ProjectGenerationConfigurationTypeFilter must return true for the config to be included (the same logic as Stream.filter has).

I've added some convenience methods in 2945eb1, too.

@mhalbritter mhalbritter added this to the 0.22.0 milestone Nov 19, 2024
@mhalbritter mhalbritter mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Exclusion of ProjectGenerationConfiguration
3 participants
@zambrovski @mhalbritter @spring-projects-issues