Upgrade to Maven Resolver 1.9.7 and Maven Resolver Provider 3.9.1 #1415
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -81,6 +82,15 @@ class MavenResolverDependencyManagementVersionResolver implements DependencyMana | |||
| LocalRepository localRepository = new LocalRepository(cacheLocation.toFile()); | |||
| this.repositorySystem = serviceLocator.getService(RepositorySystem.class); | |||
| session.setLocalRepositoryManager(this.repositorySystem.newLocalRepositoryManager(session, localRepository)); | |||
| final Properties systemProperties = new Properties(); | |||
There was a problem hiding this comment.
Can you explain this change and why you think it's necessary. I remember that something was off so I'd like to understand how you found out about this.
There was a problem hiding this comment.
Sure,
When we upgrade from maven provider 3.8.7 to 3.9.1, we get ModelBuildingException as you mentioned in #1399.
This exception occurs at line 65 in JdkVersionProfileActivator class when the value for
java.version is accessed from system properties.
In version 3.8.7, system properties value was already being set in MavenRepositorySystemUtils 3.8.7 but were not being set in MavenRepositorySystemUtils 3.9.1.
Thus I simply added the missing system properties in the way originally present in MavenRepositorySystemUtils 3.8.7.
snicoll
changed the title
|
@prithvitewatia thank you for making your first contribution to Spring Initializr. |
This PR closes issues #1399 and #1400.
Maven resolver provider 3.9.1 has dependency maven resolver 1.9.7. Thus, this PR may close both the issues.