Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kotlin project generation to not mention kotlin.version with Gradle #578

Closed
snicoll opened this issue Jan 29, 2018 · 1 comment
Closed
Assignees

Comments

@snicoll
Copy link
Contributor

snicoll commented Jan 29, 2018

See spring-projects/spring-boot#11711 (comment)

Doing it now means we'd have three ways of generating a Kotlin-based project with Gradle:

  1. In 1.x we do not have support for Kotlin in Spring Boot so everything must be generated
  2. In 2.x up to 2.0.0.RC1 (not included) we can rely on Spring Boot's support to reduce the amount of build instructions but we have to set a kotlin.version
  3. As of 2.0.0.RC1 we can but don't have to set the kotlin.version so we could just as well remove it

I am not fan of having three ways so we'll wait for 2.0 to be released to remove option 2.

@snicoll snicoll added this to the 0.5.0 milestone Jan 29, 2018
@snicoll snicoll self-assigned this Jan 29, 2018
@snicoll
Copy link
Contributor Author

snicoll commented Feb 1, 2018

Looks like I misunderstood what needs to be done. According to @sdeleuze we're good with the current state.

@snicoll snicoll closed this as completed Feb 1, 2018
@snicoll snicoll removed this from the 0.5.0 milestone Feb 1, 2018
sayeedap pushed a commit to sayeedap/initializr that referenced this issue Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant