Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciinema-player 3.8.0 fails with exports #32

Open
jvalkeal opened this issue Jun 19, 2024 · 1 comment
Open

asciinema-player 3.8.0 fails with exports #32

jvalkeal opened this issue Jun 19, 2024 · 1 comment

Comments

@jvalkeal
Copy link
Contributor

We get something like:

[14:07:34.284] FATAL (antora): Package subpath './dist/bundle/asciinema-player.min.js' is not defined by "exports" in /home/jvalkealahti/repos/spring/spring-cli/docs-build/.gradle/npm/_npx/4d870f89192857f1/node_modules/asciinema-player/package.json
    code: "ERR_PACKAGE_PATH_NOT_EXPORTED"
    type: "Error"

Caused by asciinema/asciinema-player@8d3a7fe as we load minified js via antora and I think it uses require. Asciinema prior 3.8.0 didn't have exports in package.json.

Think it's coming from here

'asciinema-player/dist/bundle/asciinema-player.min.js',

Need to think if we pin version while searching a fix.

jvalkeal added a commit to spring-projects/spring-cli that referenced this issue Jun 19, 2024
jvalkeal added a commit to spring-projects/spring-shell that referenced this issue Jun 19, 2024
@jvalkeal
Copy link
Contributor Author

It's easy to pin asciinema in an antora build itself, so should wait what happens to asciinema/asciinema-player#263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant