This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Make 403 an allowable Pub/Sub UP status #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
suggested changes
May 21, 2020
docs/src/main/asciidoc/pubsub.adoc
Outdated
| @@ -25,6 +25,27 @@ dependencies { | |||
|
|
|||
| This starter is also available from https://start.spring.io[Spring Initializr] through the `GCP Messaging` entry. | |||
|
|
|||
| === Spring Boot Actuator Support | |||
There was a problem hiding this comment.
Why did you move this section up?
Our convention is to have configuration after deps in refdoc.
There was a problem hiding this comment.
I'll move it back. My thought was that configuration is really long for pubsub, and this needed to be more prominent, but maybe not.
meltsufin
approved these changes
May 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
=========================================
Coverage 73.91% 73.92%
- Complexity 2096 2097 +1
=========================================
Files 260 260
Lines 7576 7577 +1
Branches 785 785
=========================================
+ Hits 5600 5601 +1
Misses 1614 1614
Partials 362 362
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting this week, Cloud Pub/Sub accounts without pubsub.subscriptions.list permission (normally granted through Pub/Sub Viewer role) receive 403 Permission Denied instead of 404 Resource Not Found.
This PR makes 403 a valid healthcheck UP status and updates documentation to make actuator use more prominent.
Fixes #2374.