-
Notifications
You must be signed in to change notification settings - Fork 693
Make 403 an allowable Pub/Sub UP status #2385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but note the checkstyle failure.
docs/src/main/asciidoc/pubsub.adoc
Outdated
@@ -25,6 +25,27 @@ dependencies { | |||
|
|||
This starter is also available from https://start.spring.io[Spring Initializr] through the `GCP Messaging` entry. | |||
|
|||
=== Spring Boot Actuator Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you move this section up?
Our convention is to have configuration after deps in refdoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move it back. My thought was that configuration is really long for pubsub, and this needed to be more prominent, but maybe not.
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Codecov Report
@@ Coverage Diff @@
## master #2385 +/- ##
=========================================
Coverage 73.91% 73.92%
- Complexity 2096 2097 +1
=========================================
Files 260 260
Lines 7576 7577 +1
Branches 785 785
=========================================
+ Hits 5600 5601 +1
Misses 1614 1614
Partials 362 362
Continue to review full report at Codecov.
|
Starting this week, Cloud Pub/Sub accounts without pubsub.subscriptions.list permission (normally granted through Pub/Sub Viewer role) receive 403 Permission Denied instead of 404 Resource Not Found.
This PR makes 403 a valid healthcheck UP status and updates documentation to make actuator use more prominent.
Fixes #2374.