Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteAddrRoutePredicateFactory does not play nice with proxied/forwarded requests #155

Closed
fitzoh opened this issue Jan 14, 2018 · 0 comments
Closed

RemoteAddrRoutePredicateFactory does not play nice with proxied/forwarded requests #155

fitzoh opened this issue Jan 14, 2018 · 0 comments
Labels
enhancement
Milestone
2.0.0.M9

Comments

@fitzoh
Copy link
Contributor

fitzoh commented Jan 14, 2018

Enhancement:

RemoteAddrRoutePredicateFactory is useful if you're hitting the gateway directly, but does not respect the X-Forwarded-For header.

I'm not sure if it should default to parsing/respecting Forwarded IP's, but it should at least be an option.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Jan 14, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
e5218d6 
…-Forwarded-For` header. Addresses spring-cloud#155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Jan 14, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
16d8500 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Jan 14, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
bb1c346 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Feb 13, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
11054ae 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Feb 14, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
5a11f8d 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Feb 14, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
14b1e21 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
fitzoh added a commit to fitzoh/spring-cloud-gateway that referenced this issue Mar 19, 2018
@fitzoh
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
7bf78a4 
…-Forwarded-For` header. Fixes spring-cloudgh-155.
@spencergibb spencergibb added this to the 2.0.0.M9 milestone Mar 19, 2018
@spencergibb spencergibb mentioned this issue Mar 19, 2018
Closed
bijukunjummen pushed a commit to bijukunjummen/spring-cloud-gateway that referenced this issue Jun 8, 2018
@fitzoh @bijukunjummen
Update RemoteAddrRoutePredicateFactory to optionally respect the `X…
dbd23a6 
…-Forwarded-For` header. Addresses spring-cloud#155. (spring-cloud#156)

* Update `RemoteAddrRoutePredicateFactory` to optionally respect the `X-Forwarded-For` header. Fixes spring-cloudgh-155.

* Make function to extract client IP configurable. Add additional method for extracting client IP with is safer from spoofing of X-Forwarded-For header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0.M9
Development

No branches or pull requests
2 participants
@fitzoh @spencergibb