Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeployerIntegrationTestTaskApplication #65

Closed
sabbyanandan opened this issue May 16, 2016 · 2 comments
Closed

Add DeployerIntegrationTestTaskApplication #65

sabbyanandan opened this issue May 16, 2016 · 2 comments
Assignees
@trisberg
Milestone
1.0.0.RC1

Comments

@sabbyanandan
Copy link
Contributor

As a developer, I'd like to add DeployerIntegrationTestTaskApplication, so I can use it for IT tests to evaluate TaskLauncher implementation across various deployers.
@sabbyanandan sabbyanandan added this to the 1.0.0.RC1 milestone May 16, 2016
@markfisher
Copy link
Contributor

markfisher commented Jun 2, 2016 •
edited
Loading

why not rely upon the existing DeployerIntegrationTestApplication with its killDelay property set? (we could also add an exit code property so that it could exit "normally" after the kill delay if so configured) cc @ericbottard @mminella

@trisberg
Copy link
Member

trisberg commented Jun 2, 2016

That sounds like a plan.

@trisberg trisberg added in progress and removed ready labels Jun 2, 2016
@trisberg trisberg self-assigned this Jun 2, 2016
trisberg added a commit to trisberg/spring-cloud-deployer that referenced this issue Jun 2, 2016
@trisberg
Add exit code property to be used for task tests
47ab0d9 
Resolves spring-cloud#65
@trisberg trisberg mentioned this issue Jun 2, 2016
Merged
@trisberg trisberg added in pr and removed in progress labels Jun 2, 2016
@markfisher markfisher removed the in pr label Jun 2, 2016
corneil pushed a commit that referenced this issue Mar 22, 2023
@trisberg @markpollack
Fix local deployer issues
e7cceab 
- add switch to allow testing with docker images instead of Maven artifacts

- use SPRING_CLOUD_DEPLOYER_SPI_TEST_USE_DOCKER=true

- set instance env vars like INSTANCE_INDEX for app when deployed as docker image

- pass command line args to app when deployed as docker image

- for docker, expose the port used by the container instead of 8080

- support deploying Boot 2.0 apps by changing to pass app properties as command line args

Resolves #62
Resolves #65
Resolves #66
Resolves #67

Add support for passing app props as SPRING_APPLICATION_JSON

- moving deployer provided env vars out of the LocalDeployerProperties

Rename test to remove Abstract prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trisberg trisberg

Labels
None yet
Projects
None yet
Milestone
1.0.0.RC1
Development

No branches or pull requests
3 participants
@trisberg @markfisher @sabbyanandan