Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyone who get trouble using property additional container & volumeMounts #454

Closed
Kim-menu opened this issue Mar 19, 2024 · 2 comments · Fixed by #470
Closed

Anyone who get trouble using property additional container & volumeMounts #454

Kim-menu opened this issue Mar 19, 2024 · 2 comments · Fixed by #470
Assignees
Labels
for/team-attention For team attention

Comments

@Kim-menu
Copy link

Description:
I just want sidecar container(additional container) with my task container.
I put property like below

deployer.{myapp}.kubernetes.volumes=[{name: 'promtail-config', configMap: {name: promtail-config, items: [{key: promtail.yaml, path: promtail.yaml}]}}]
deployer.{myapp}.kubernetes.additional-containers=[{name: 'promtail',image: image-path-of-promtail, ports:[{protocol: TCP,containerPort: 8080}],args: ["-config.file=/home/conf/promtail.yaml"],volumeMounts: [{name: 'promtail-config', mountPath: '/home/conf'}]}]

of course, in my k8s cluster there is definitely promtail-config yaml object.

first, I put property for volumes
second, I put property for additional container. Then, I describe info about volumeMounts

but I cannot launch task with this error log.

Message: Pod "test-task-9rq9ojo3k0" is invalid: spec.containers[1].volumeMounts[0].name: Not found: "promtail-config".

Did I understand k8s system badly?....

I searched about this property or example for it, Unfortunately, there is no information about additional container's volume in SCDF

Release versions:
SCDF 2.10.2

Custom apps:
Task

Is there anyone who had problem like my situation..?

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Mar 19, 2024
@corneil corneil added the for/team-attention For team attention label Mar 19, 2024
@cppwfs cppwfs removed the status/need-triage Team needs to triage and take a first look label Mar 19, 2024
@cppwfs cppwfs transferred this issue from spring-cloud/spring-cloud-dataflow Jun 4, 2024
@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jun 4, 2024
@cppwfs cppwfs removed the status/need-triage Team needs to triage and take a first look label Jun 4, 2024
@corneil
Copy link
Contributor

corneil commented Aug 5, 2024

@Kim-menu Thank you for reporting.
While we investigate I would suggest consider using promtail service discovery then you won't need a sidecar for each pod.

@corneil
Copy link
Contributor

corneil commented Aug 5, 2024

@Kim-menu Did you create a ConfigMap resource named promtail-config?

corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Aug 6, 2024
corneil added a commit that referenced this issue Aug 27, 2024
* Check volume requirement on all containers.
* Added volumes and additional containers to test that both are mapped.
* Moved comment. Added negative test where one volume mount is absent.

Fixes #454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/team-attention For team attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants