Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support backoffLimit on Job created from CronJob #407

Open
chrisjs opened this issue Oct 7, 2020 · 3 comments
Open

Support backoffLimit on Job created from CronJob #407

chrisjs opened this issue Oct 7, 2020 · 3 comments
Assignees
@onobc
Labels
status/in-progress Something is happening

Comments

@chrisjs
Copy link
Contributor

chrisjs commented Oct 7, 2020

If the deployer property backoffLimit (either globally or per app) is set, when creating a schedule via CronJob, set the backoffLimit into the job spec
@chrisjs chrisjs added type/enhancement Is an enhancement request type/help-needed Calling help labels Oct 7, 2020
@chrisjs chrisjs mentioned this issue Oct 7, 2020
Closed
@deepak5127
Copy link
Contributor

@chrisjs Shall i work on this ?

@chrisjs
Copy link
Contributor Author

chrisjs commented Feb 3, 2021

sure - feel free to work on any open issues. thanks!

@deepak5127
Copy link
Contributor

@ilayaperumalg @chrisjs Should I combine this with GH-4294 ? May if there are other changes related to deployer / task / scheduler properties should I combine into one PR ?

@onobc onobc self-assigned this Apr 26, 2023
@onobc onobc added status/in-progress Something is happening and removed type/enhancement Is an enhancement request type/help-needed Calling help labels Apr 26, 2023
onobc added a commit to onobc/spring-cloud-deployer that referenced this issue Apr 27, 2023
@onobc
Add backoffLimit to KubernetesScheduler
0c961a8 
See spring-cloud/spring-cloud-deployer-kubernetes#407
@onobc onobc mentioned this issue Apr 27, 2023
Merged
onobc added a commit to spring-cloud/spring-cloud-deployer that referenced this issue Apr 28, 2023
@onobc
Add backoffLimit to KubernetesScheduler (#392)
2a75464 
* Add backoffLimit to KubernetesScheduler

See spring-cloud/spring-cloud-deployer-kubernetes#407
onobc added a commit to onobc/spring-cloud-deployer-kubernetes that referenced this issue Apr 30, 2023
@onobc
Backport "Add backoffLimit to KubernetesScheduler (spring-cloud#392)"
c180940 
See spring-cloud#407
@onobc onobc mentioned this issue Apr 30, 2023
Merged
onobc added a commit that referenced this issue Apr 30, 2023
@onobc
Backport "Add backoffLimit to KubernetesScheduler (#392)" (#538)
117840b 
See #407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onobc onobc

Labels
status/in-progress Something is happening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepak5127 @chrisjs @onobc