Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support to specify priority and allow for template override #1882

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

wwadge
Copy link
Contributor

@wwadge wwadge commented Apr 5, 2023

Allows specifying priority eg

SpringCloudContractRestDocs.dslContract(Maps.of("priority", 1))))

and makes it possible to override the dsl template

 new ContractDslSnippet(){
                            @Override
                            protected String getTemplate() {
                                return "custom-dsl-contract";
                            }
                        }));

(template must live in resources/org/springframework/restdocs/templates)

Fixes gh-1818

@pivotal-cla
Copy link

@wwadge Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@wwadge Thank you for signing the Contributor License Agreement!

@marcingrzejszczak marcingrzejszczak added this to the 4.0.3 milestone Apr 6, 2023
@marcingrzejszczak marcingrzejszczak merged commit e4d19d8 into spring-cloud:main Apr 6, 2023
@wwadge wwadge deleted the gh-1818 branch April 6, 2023 08:06
@marcingrzejszczak
Copy link
Contributor

Thanks @wwadge for your PR! Actually one more question, can you also add a PR with docs update that will mention this feature?

@marcingrzejszczak marcingrzejszczak removed this from the 4.0.3 milestone Apr 6, 2023
@wwadge
Copy link
Contributor Author

wwadge commented Apr 6, 2023

Sure - let me see if I can find the right docs to update and open a new PR

@wwadge
Copy link
Contributor Author

wwadge commented Apr 6, 2023

Docs here: #1883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support priority in Restdocs generated contract
4 participants