Spanner - add NUMERIC type #2518
Conversation
| @@ -91,6 +94,7 @@ | |||
| .put(double[].class, AbstractStructReader::getDoubleArray) | |||
| .put(long[].class, AbstractStructReader::getLongArray) | |||
| .put(boolean[].class, AbstractStructReader::getBooleanArray) | |||
| .put(BigDecimal.class, AbstractStructReader::getBigDecimal) | |||
There was a problem hiding this comment.
This looks like a duplicate of the above map, but there's probably some obscure reason for it. :)
| + "FROM trades WHERE ( LOWER(action)=LOWER(@tag0) " | ||
| + "AND ticker=@tag1 ) OR " | ||
| + "( trader_id=@tag2 AND price<@tag3 ) OR ( price>=@tag4 AND id<>NULL AND " | ||
| + "trader_id=NULL AND trader_id LIKE @tag7 AND price=TRUE AND price=FALSE AND " | ||
| + "price>@tag10 AND price<=@tag11 AND price IN UNNEST(@tag12) ) ORDER BY id DESC LIMIT 3"; | ||
| + "price>@tag10 AND price<=@tag11 AND price IN UNNEST(@tag12) " |
There was a problem hiding this comment.
price is actually a perfect field to use BigDecimal for.
| @@ -91,6 +94,7 @@ | |||
| .put(double[].class, AbstractStructReader::getDoubleArray) | |||
| .put(long[].class, AbstractStructReader::getLongArray) | |||
| .put(boolean[].class, AbstractStructReader::getBooleanArray) | |||
| .put(BigDecimal.class, AbstractStructReader::getBigDecimal) | |||
There was a problem hiding this comment.
same nit -- should this go before the primitive arrays?
| @@ -71,6 +73,7 @@ | |||
| .put(double[].class, AbstractStructReader::getDoubleArray) | |||
| .put(long[].class, AbstractStructReader::getLongArray) | |||
| .put(boolean[].class, AbstractStructReader::getBooleanArray) | |||
| .put(BigDecimal.class, AbstractStructReader::getBigDecimal) | |||
There was a problem hiding this comment.
nit: Should this go to before array types?
Codecov Report
@@ Coverage Diff @@
## master #2518 +/- ##
=============================================
+ Coverage 0.00% 74.25% +74.25%
- Complexity 0 2162 +2162
=============================================
Files 267 267
Lines 7755 7760 +5
Branches 0 803 +803
=============================================
+ Hits 0 5762 +5762
- Misses 0 1628 +1628
- Partials 0 370 +370
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| @@ -27,7 +25,20 @@ private Util() { | |||
| } | |||
|
|
|||
| public static String extractDatabasePath(String parent) { | |||
| return parent.substring(0, StringUtils.ordinalIndexOf(parent, "/", 4)); | |||
| //the parent looks like this: projects/{project_id}/databases/{database_id}/... | |||
There was a problem hiding this comment.
This is unrelated. Can we please put it in a separate PR?
…o spanner-numeric-type
|
Kudos, SonarCloud Quality Gate passed!
|
* Spanner - add NUMERIC type; fixes #2515
fixes #2515