Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add secret manager enabled property to properties metadata #2363

Merged
merged 1 commit into from
May 15, 2020
Merged

Conversation

dzou
Copy link
Contributor

@dzou dzou commented May 13, 2020

This adds the missing secretmanager enable property to the project metadata.

Fixes #2362.

@dzou dzou requested a review from meltsufin May 13, 2020 17:00
@sonarcloud
Copy link

sonarcloud bot commented May 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #2363 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2363      +/-   ##
============================================
- Coverage     74.04%   73.91%   -0.14%     
  Complexity     2098     2098              
============================================
  Files           259      260       +1     
  Lines          7563     7575      +12     
  Branches        785      785              
============================================
- Hits           5600     5599       -1     
- Misses         1603     1616      +13     
  Partials        360      360              
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 73.91% <ø> (-0.14%) 2098.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 65.51% <0.00%> (-6.90%) 6.00% <0.00%> (ø%)
...cp/autoconfigure/spanner/GcpSpannerProperties.java 60.37% <0.00%> (-2.89%) 17.00% <0.00%> (ø%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589504d...b211812. Read the comment docs.

@dzou dzou merged commit e86a9e4 into master May 15, 2020
@dzou dzou deleted the sm-config branch May 15, 2020 16:54
@eddumelendez
Copy link
Contributor

the entry is now duplicated. it was renamed as part of #2302

@meltsufin
Copy link
Contributor

True! @dzou Can you revert this?

@dzou
Copy link
Contributor Author

dzou commented May 26, 2020

Nice catch @eddumelendez ! Will revert. Thanks for the heads up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

add secret manager bootstrap enabled for autocompletion
3 participants