This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 693
Create protocol for specifying secrets' project and versions #2302
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
222575d
Create protocol for specifying secrets
dzou 69ea656
Fix assert notNull statements
dzou d9c7592
reduce visibility of SecretManagerPropertyIdentifier
dzou 3d87209
PR Comments
dzou f8d5fd2
PR Comments
dzou 231b208
update sample
dzou 4ae2c45
Fix checkstyle
dzou 1f20609
Fix sample
dzou f026809
make private visibility for sample fields
dzou 5b01c33
fix tests
dzou f00e1c3
add visible for testing comment
dzou 32a8165
documentation updates
dzou d54c7d6
Update secret manager enabled property name.
dzou 8b145f1
remove enabled property from tests
dzou 2ce82cb
PR Comments
dzou 41c83f0
template changes + refactor
dzou 1116fb8
secret manager prefix change to sm://
dzou c48a3a5
add comments
dzou 968e44a
fix checkstyle
dzou a81143b
PR Comments
dzou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 0 additions & 82 deletions
82
...ingframework/cloud/gcp/autoconfigure/secretmanager/GcpSecretManagerAutoConfiguration.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs need to be updated following this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, updated docs.