Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

fix delete for void return type #2177

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix delete for void return type #2177

merged 1 commit into from
Feb 5, 2020

Conversation

dmitry-s
Copy link
Contributor

@dmitry-s dmitry-s commented Feb 5, 2020

fixes #2169

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #2177 into master will increase coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2177      +/-   ##
============================================
+ Coverage     72.76%   72.99%   +0.22%     
- Complexity     1933     1954      +21     
============================================
  Files           245      247       +2     
  Lines          7083     7105      +22     
  Branches        733      733              
============================================
+ Hits           5154     5186      +32     
+ Misses         1589     1583       -6     
+ Partials        340      336       -4
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 72.99% <0%> (+0.22%) 1954 <0> (+21) ⬆️
Impacted Files Coverage Δ Complexity Δ
...store/repository/query/PartTreeDatastoreQuery.java 90.5% <0%> (+6.32%) 59 <0> (+9) ⬆️
...k/cloud/gcp/data/spanner/core/SpannerTemplate.java 76.71% <0%> (-0.3%) 86% <0%> (ø)
...anner/core/admin/SpannerDatabaseAdminTemplate.java 82.81% <0%> (-0.27%) 20% <0%> (ø)
...data/spanner/repository/query/SqlSpannerQuery.java 84.8% <0%> (-0.24%) 29% <0%> (ø)
...gcp/data/spanner/core/convert/ConversionUtils.java 88.46% <0%> (ø) 11% <0%> (ø) ⬇️
...epository/query/SpannerStatementQueryExecutor.java 83.33% <0%> (ø) 52% <0%> (ø) ⬇️
...configure/pubsub/health/PubSubHealthIndicator.java 92.3% <0%> (ø) 3% <0%> (?)
...health/PubSubHealthIndicatorAutoConfiguration.java 100% <0%> (ø) 2% <0%> (?)
...store/repository/query/PartTreeFirestoreQuery.java 89.61% <0%> (+1.37%) 19% <0%> (+7%) ⬆️
...tastore/GcpDatastoreEmulatorAutoConfiguration.java 72.41% <0%> (+6.89%) 6% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901882a...5b6d25b. Read the comment docs.

@dmitry-s dmitry-s merged commit 8d8adbe into master Feb 5, 2020
@dmitry-s dmitry-s deleted the datastore-delete-void branch February 5, 2020 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Datastore deleteBy methods
3 participants