Don't call spreecloud in test env in admin (#317)

* Don't call spreecloud in test env in admin * Update base_helper.rb
spree · May 22, 2024 · 4187373 · 4187373
1 parent 2cf8a1d
commit 4187373
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/helpers/spree/admin/base_helper.rb b/app/helpers/spree/admin/base_helper.rb
@@ -287,8 +287,12 @@ def taxon_wysiwyg_editor_enabled?
         Spree::Backend::Config[:taxon_wysiwyg_editor_enabled]
       end
 
+      def spree_admin_show_version?
+        can?(:admin, current_store) && Spree::Backend::RuntimeConfig[:admin_show_version]
+      end
+
       def spree_update_available?
-        @spree_update_available ||= Spree::Admin::Updater.update_available?
+        @spree_update_available ||= !Rails.env.test? && Spree::Admin::Updater.update_available?
       end
     end
   end

diff --git a/app/views/spree/admin/shared/_version.html.erb b/app/views/spree/admin/shared/_version.html.erb
@@ -1,10 +1,10 @@
-<% if can?(:admin, current_store) && Spree::Backend::RuntimeConfig[:admin_show_version] %>
+<% if spree_admin_show_version? %>
   <div
     class="spree-version px-3 py-2"
     aria-label="Spree Commerce version">
     <div class="d-flex align-items-center justify-content-between">
       <span class="text-muted small">
-        <%= link_to Spree.version, "https://github.com/spree/spree/releases/tag/v#{Spree.version.gsub(/\.beta|\.rc\d+/, '')}", target: '_blank' %>
+        <%= link_to Spree.version, "https://github.com/spree/spree/releases/tag/v#{Spree.version}", target: '_blank' %>
       </span>
       <% if spree_update_available? %>
         <span class="small text-info">