Skip to content

Commit

Permalink
changing the analytics API host name (ampproject#8888)
Browse files Browse the repository at this point in the history
  • Loading branch information
Nitenrda Kumar authored and Eric Kenney committed May 3, 2017
1 parent 2aa286c commit 9c2bbaf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion examples/analytics.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ <h1 id="top">AMP Analytics</h1>
{
"transport": {"beacon": false, "xhrpost": false},
"requests": {
"pageview": "https://ibeats.indiatimes.com/iBeat/pageTrendlogAmp.html?h=${h}&d=${d}&url=${url}&k=${k}&ts=${ts}&ch=${ch}&sid=${sid}&at=${at}&ref=${ref}&aid=${aid}&loc=${loc}&ct=${ct}&cat=${cat}&scat=${scat}&ac=${ac}&tg=${tg}&ctids=${ctids}&pts=${pts}&auth=${auth}&pos=${pos}&utmvsi=${utmvsi}&utmcsr=${utmcsr}&utmccn=${utmccn}&utmcmd=${utmcmd}&utma=${utma}&iBeatField=${iBeatField}"
"pageview": "https://ibeat.indiatimes.com/iBeat/pageTrendlogAmp.html?h=${h}&d=${d}&url=${url}&k=${k}&ts=${ts}&ch=${ch}&sid=${sid}&at=${at}&ref=${ref}&aid=${aid}&loc=${loc}&ct=${ct}&cat=${cat}&scat=${scat}&ac=${ac}&tg=${tg}&ctids=${ctids}&pts=${pts}&auth=${auth}&pos=${pos}&utmvsi=${utmvsi}&utmcsr=${utmcsr}&utmccn=${utmccn}&utmcmd=${utmcmd}&utma=${utma}&iBeatField=${iBeatField}"
},
"vars": {
"aid":"99999999"
Expand Down
6 changes: 3 additions & 3 deletions extensions/amp-analytics/0.1/test/vendor-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@
"custom": "https://$apiEndpoint/event/pixel?api.api_key=$writeKey&prop._platform=amp&prop._device_id=_client_id_&prop.locale=_browser_language_&prop.path=_canonical_path_&prop.url=_canonical_url_&prop.color_depth=_screen_color_depth_&prop._referrer=_document_referrer_&prop.title=_title_&prop.timezone=_timezone_&prop._time=_timestamp_&prop.resolution=_screen_width_ × _screen_height_&collection=$collection"
},
"ibeatanalytics": {
"host": "https://ibeats.indiatimes.com",
"base": "https://ibeats.indiatimes.com/iBeat/pageTrendlogAmp.html",
"pageview": "https://ibeats.indiatimes.com/iBeat/pageTrendlogAmp.html?&h=$h&d=$h&url=$url&k=$key&ts=$time&ch=$channel&sid=$uid&at=$agentType&ref=_document_referrer_&aid=$aid&loc=1&ct=1&cat=$cat&scat=$scat&ac=1&tg=$tags&ctids=$catIds&pts=$pagePublishTime&auth=$author&pos=$position&iBeatField=$ibeatFields&cid=_client_id_",
"host": "https://ibeat.indiatimes.com",
"base": "https://ibeat.indiatimes.com/iBeat/pageTrendlogAmp.html",
"pageview": "https://ibeat.indiatimes.com/iBeat/pageTrendlogAmp.html?&h=$h&d=$h&url=$url&k=$key&ts=$time&ch=$channel&sid=$uid&at=$agentType&ref=_document_referrer_&aid=$aid&loc=1&ct=1&cat=$cat&scat=$scat&ac=1&tg=$tags&ctids=$catIds&pts=$pagePublishTime&auth=$author&pos=$position&iBeatField=$ibeatFields&cid=_client_id_",
},
}
4 changes: 2 additions & 2 deletions extensions/amp-analytics/0.1/vendors.js
Original file line number Diff line number Diff line change
Expand Up @@ -1313,8 +1313,8 @@ export const ANALYTICS_CONFIG = /** @type {!JSONType} */ ({
},
'ibeatanalytics': {
'requests': {
'host': 'https://ibeats.indiatimes.com',
'base': 'https://ibeats.indiatimes.com/iBeat/pageTrendlogAmp.html',
'host': 'https://ibeat.indiatimes.com',
'base': 'https://ibeat.indiatimes.com/iBeat/pageTrendlogAmp.html',
'pageview': '${base}?' +
'&h=${h}' +
'&d=${h}' +
Expand Down

0 comments on commit 9c2bbaf

Please sign in to comment.