fix(elastigroup/aws): retry creation for "cant_create_group" errors #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranp
pushed a commit
that referenced
this pull request
Apr 28, 2021
liranp
added a commit
that referenced
this pull request
Apr 28, 2021
liranp
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tend to many Elastigroup instances and according to the support staff we're running into AWS rate limits. We don't have much visibility into the rate limit, but it tends to manifest as this sort of error:
If it's a AWS rate limit, seems it should be retryable.
Unsure if this is visible to the maintainers, but this is the support request for reference: https://support.spot.io/hc/en-us/requests/1405523.