fix(web-scripts): positional args were being stripped out #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positional args were not making there way through to the web-scripts commands, because commander 5 changed how we need to handle args. there is now conveniently an `args` array on the command which contains all args (positional or flagged) in order, which seems to be more reliably correct from what the user inputs compared to using the parseOptions(process.argv) method.
|
@pmowrer, we found another issue that was introduced by tj/commander.js#1138, but I think this should solve both now. |
kaityhallman
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the best test case for this is
web-scripts test filename, which currently doesn't work.positional args were not making there way through to the web-scripts commands, because commander 5 changed how we need to handle args. there is now conveniently an
argsarray on the command which contains all args (positional or flagged) in order, which seems to be more reliably correct from what the user inputs compared to using theparseOptions(process.argv)method.