Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple dataflow in ratatool-scalacheck #717

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

RustedBones
Copy link
Contributor

@RustedBones RustedBones commented Feb 29, 2024

Do not import class that may be missing from user's classpath

Compute key size using machine memory instead of CPUs

Do not import class that may be missing from user's classpath

Compute heap size using machine memory instead of CPUs
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 70.74%. Comparing base (499dbad) to head (2725450).

Files Patch % Lines
...ala/com/spotify/ratatool/samplers/BigSampler.scala 44.44% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
- Coverage   70.99%   70.74%   -0.26%     
==========================================
  Files          44       44              
  Lines        1824     1839      +15     
  Branches      292      316      +24     
==========================================
+ Hits         1295     1301       +6     
- Misses        529      538       +9     
Flag Coverage Δ
ratatoolCli 2.87% <0.00%> (-0.04%) ⬇️
ratatoolCommon 0.00% <ø> (ø)
ratatoolDiffy 32.51% <0.00%> (-0.32%) ⬇️
ratatoolExamples 17.22% <0.00%> (-0.16%) ⬇️
ratatoolSampling 61.78% <44.44%> (-0.30%) ⬇️
ratatoolScalacheck 79.34% <ø> (ø)
ratatoolShapeless 4.14% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RustedBones RustedBones merged commit 6e409c4 into master Feb 29, 2024
1 check passed
@RustedBones RustedBones deleted the decoupled-dataflow branch February 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants