Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade some libs to match scio #676

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

catherinejelder
Copy link
Contributor

@catherinejelder catherinejelder commented Oct 6, 2023

it seems good to match versions for dependencies we share with scio

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #676 (baed14b) into master (aa927ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #676   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          40       40           
  Lines        1710     1710           
  Branches      140      140           
=======================================
  Hits         1221     1221           
  Misses        489      489           
Flag Coverage Δ
ratatoolCli 3.07% <ø> (ø)
ratatoolCommon ∅ <ø> (?)
ratatoolDiffy 30.80% <ø> (ø)
ratatoolExamples 15.94% <ø> (ø)
ratatoolSampling 62.58% <ø> (ø)
ratatoolScalacheck 81.67% <ø> (ø)
ratatoolShapeless 4.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@catherinejelder catherinejelder marked this pull request as ready for review October 6, 2023 16:00
Copy link
Contributor

@steveroy0226 steveroy0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@catherinejelder catherinejelder merged commit f9ccbba into master Oct 6, 2023
3 checks passed
@catherinejelder catherinejelder deleted the catherinejelder-patch-1 branch October 6, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants