Skip to content

Commit

Permalink
docs: Set minimum versions for sphinx (#1760)
Browse files Browse the repository at this point in the history
I saw that the build was failing, hence this is my attempt to fix it,
altough I don't know how to test this before merging it.
See https://readthedocs.org/projects/luigi/builds/4189801/

Unfortunately I couldn't find a way to connect a webhook between GitHub
PRs and readthedocs: readthedocs/readthedocs.org#1340

The reason I believe a version bump would fix it is because I see
exactly the same error as in sphinx-doc/sphinx#2465 and readthedocs
seem to use 1.3.5, causing the pdf docs to be outdated.
  • Loading branch information
Tarrasch authored Jul 13, 2016
1 parent 6d4dbf0 commit b98898b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _warn_node(self, msg, node, *args, **kwargs):
# -- General configuration ------------------------------------------------

# If your documentation needs a minimal Sphinx version, state it here.
#needs_sphinx = '1.0'
needs_sphinx = '1.4.4'

# Add any Sphinx extension module names here, as strings. They can be
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ commands = isort -w 120 -rc luigi test examples bin
# Call this using `tox -e docs`.
deps =
sqlalchemy
Sphinx==1.4.2
Sphinx>=1.4.4<1.5
sphinx_rtd_theme
commands =
# build API docs
Expand Down

0 comments on commit b98898b

Please sign in to comment.