This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
helios-solo: skydns workaround to allow DNS responses up to 32768 bytes #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR; skydns does not handle TCP well. We already worked around this in #900. See thar PR for more context. However, that change only fixed the problem to an extent as we still have the same issue once the responses are >4096 bytes. This change extends that workaround to allow us to survive responses up to 32768 bytes in size. This change does not fix the issue, but should make it more rare.
|
Nice work. Could you also document somewhere (for instance |
Current coverage is 51.65% (diff: 100%)@@ master #1081 diff @@
==========================================
Files 270 270
Lines 12934 12934
Methods 0 0
Messages 0 0
Branches 1678 1678
==========================================
+ Hits 6672 6681 +9
+ Misses 5759 5751 -8
+ Partials 503 502 -1
|
|
@mattnworb Note added to docs. |
|
tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR; skydns does not handle TCP well. We already worked around this
in #900. See thar PR for more context.
However, that change only fixed the problem to an extent as we still have
the same issue once the responses are >4096 bytes.
This change extends that workaround to allow us to survive responses up to
32768 bytes in size. This change does not fix the issue, but should make it
more rare.