Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing tests for reading just produced output avro files. #578

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rulle-io
Copy link
Contributor

@rulle-io rulle-io commented Feb 6, 2023

Print user-provided Avro schema to a log.

Unit-tests to illustrate existing issues when incorrect user-supplied Avro schema is used. #579

Testing

  • "Unit tests are included"

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %) and/or integration tests.
  • Ensure code formating (use mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)
  • Document any relevant additions/changes in the appropriate spot in javadocs/docs/README.

Print user-provided Avro schema to a log.
@rulle-io rulle-io requested a review from labianchin February 8, 2023 09:11
int result =
new DataFileReadTool()
.run(System.in, System.out, System.err, Arrays.asList("--head", outputAvroFile));
Assert.assertEquals(0, result); // old school :)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "old school :)" mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 returned meaning "success".


int result =
new DataFileReadTool()
.run(System.in, System.out, System.err, Arrays.asList("--head", outputAvroFile));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need DataFileReadTool from a separate jar. Can we simply use something like the other tests is using, readAvroRecords(outputPath.resolve("part-00000-of-00001.avro").toFile(), schema).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the idea is to use an "independent" but trustworthy tool to illustrate real-world usage.

rulle-io and others added 3 commits August 27, 2023 18:15
…hema.java

Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
…t.java

Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
…t.java

Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants