feat: logging support via slog #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
fabriziodemaria,
mfranberg,
vahidlazio,
DennisPersson and
nickybondarenko
as code owners
nicklasl
force-pushed
the
logging-support
branch
2 times, most recently
from
f8f4893 to
1e098f6
Compare
nicklasl
force-pushed
the
logging-support
branch
from
1e098f6 to
74014a8
Compare
vahidlazio
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a major clean up of the Readme to put the SDK front and center.
It also introduces support via an slog backport as described in the PR. As well as adding a couple of log prints.
Using the backport we can keep the go version to 1.19 for yet a while until we've learned more about what our users need.