feat!: Add custom baseURL config for resolve #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl,
DennisPersson and
nickybondarenko
as code owners
fabriziodemaria
commented
Sep 9, 2024
Signed-off-by: Fabrizio Demaria <[email protected]>
nicklasl
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
LGTM. And good that you marked it breaking.
When you merge this, please add some details in the additional commit description on what is the breaking part and how we customers are envisioned to migrate. Doesn't need to be anything long but I think it would be nice to have that part in the release notes.
Signed-off-by: Fabrizio Demaria <[email protected]>
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
changed the title
fabriziodemaria
commented
Sep 10, 2024
Comment on lines
+60
to
+62
| if config.APIResolveBaseUrl == "" { | ||
| e.confidence.Config.APIResolveBaseUrl = DefaultAPIResolveBaseUrl | ||
| } |
There was a problem hiding this comment.
c.NewConfidenceBuilder().SetAPIConfig(c.APIConfig{APIKey: "API_KEY"}).Build()
Instantiating the APIConfig{} struct directly (instead of using our constructors NewAPIConfig*) as the example causes the baseUrl to be an empty string. This code is a way to counteract that
nicklasl
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How was it tested
This setup has been manually tested with the Demo App both in remote and side-car environments.
Breaking Changes
Regionis now removed, so if the integration is using this configuration it will need to be updated to fix compilation issues