fix: Context structure #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
requested review from
fabriziodemaria,
mfranberg,
nicklasl,
DennisPersson and
nickybondarenko
as code owners
vahidlazio
force-pushed
the
context-structure
branch
from
b5cbe57 to
60a01bb
Compare
vahidlazio
force-pushed
the
context-structure
branch
from
60a01bb to
b310b69
Compare
vahidlazio
force-pushed
the
context-structure
branch
from
b310b69 to
4be06a7
Compare
fabriziodemaria
approved these changes
May 30, 2024
| @@ -83,10 +83,14 @@ func (e Confidence) PutContext(key string, value interface{}) { | |||
| e.contextMap[key] = value | |||
| } | |||
|
|
|||
| func (e Confidence) Track(ctx context.Context, eventName string, message map[string]interface{}) *sync.WaitGroup { | |||
| newMap := e.GetContext() | |||
| func (e Confidence) Track(ctx context.Context, eventName string, data map[string]interface{}) *sync.WaitGroup { | |||
There was a problem hiding this comment.
nit: eventName should be the first argument
There was a problem hiding this comment.
the first context is coming from go, it's not confidence context. i think it's pretty standard to have the go context as the first parameter. you still think we should move it?
There was a problem hiding this comment.
Ah you are right, no probably makes sense to keep it there then
fabriziodemaria
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.