feat: Add SDK id and version to requests #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
Calibretto,
mfranberg,
vahidlazio,
nicklasl,
DennisPersson and
nickybondarenko
as code owners
fabriziodemaria
force-pushed
the
sdk-metadata2
branch
2 times, most recently
from
8f617cc to
58f97b4
Compare
fabriziodemaria
commented
Nov 14, 2023
| @@ -8,12 +8,14 @@ Before starting to use the provider, it can be helpful to read through the gener | |||
| and get familiar with the concepts. | |||
|
|
|||
| ## Adding the dependency | |||
| <!---x-release-please-start-version--> | |||
There was a problem hiding this comment.
Unrelated to the goal of this PR, but it's good to have release-please also updating the readme
fabriziodemaria
force-pushed
the
sdk-metadata2
branch
from
58f97b4 to
9ed0202
Compare
DennisPersson
approved these changes
Nov 15, 2023
vahidlazio
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #32
✅ Manually verified that this works end-to-end