default type should be a map

spotify · Jun 3, 2024 · 541605d · 541605d
1 parent d56de80
commit 541605d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/confidence/confidence.go b/pkg/confidence/confidence.go
@@ -174,12 +174,12 @@ func (e Confidence) GetStringValue(ctx context.Context, flag string, defaultValu
 	return e.GetStringFlag(ctx, flag, defaultValue).Value
 }
 
-func (e Confidence) GetObjectFlag(ctx context.Context, flag string, defaultValue string) InterfaceResolutionDetail {
+func (e Confidence) GetObjectFlag(ctx context.Context, flag string, defaultValue map[string]interface{}) InterfaceResolutionDetail {
 	resp := e.ResolveFlag(ctx, flag, defaultValue, reflect.Map)
 	return resp
 }
 
-func (e Confidence) GetObjectValue(ctx context.Context, flag string, defaultValue string) interface{} {
+func (e Confidence) GetObjectValue(ctx context.Context, flag string, defaultValue map[string]interface{}) interface{} {
 	return e.GetObjectFlag(ctx, flag, defaultValue).Value
 }
 

diff --git a/pkg/confidence/confidence_internal_test.go b/pkg/confidence/confidence_internal_test.go
@@ -63,7 +63,7 @@ func TestResolveObjectValue(t *testing.T) {
 	client := client(t, templateResponse(), nil)
 	client.PutContext("targeting_key", "user1")
 
-	evalDetails := client.GetObjectFlag(context.Background(), "test-flag.struct-key", "default")
+	evalDetails := client.GetObjectFlag(context.Background(), "test-flag.struct-key", map[string]interface{}{})
 	_, ok := evalDetails.Value.(map[string]interface{})
 	assert.True(t, ok)
 }
@@ -88,7 +88,7 @@ func TestResolveWholeFlagAsObject(t *testing.T) {
 	client := client(t, templateResponse(), nil)
 	client.PutContext("targeting_key", "user1")
 
-	evalDetails := client.GetObjectFlag(context.Background(), "test-flag", "default")
+	evalDetails := client.GetObjectFlag(context.Background(), "test-flag", map[string]interface{}{})
 	_, ok := evalDetails.Value.(map[string]interface{})
 	assert.True(t, ok)
 }
@@ -97,7 +97,7 @@ func TestResolveWholeFlagAsObjectWithInts(t *testing.T) {
 	client := client(t, templateResponse(), nil)
 	client.PutContext("targeting_key", "user1")
 
-	evalDetails := client.GetObjectFlag(context.Background(), "test-flag", "default")
+	evalDetails := client.GetObjectFlag(context.Background(), "test-flag", map[string]interface{}{})
 
 	value, _ := evalDetails.Value.(map[string]interface{})
 	rootIntValue := value["integer-key"]