-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate usage of owner_id param in CheckUsersFollowPlaylist requests to match the updated endpoint #397
Merged
dargmuesli
merged 1 commit into
spotify-web-api-java:master
from
Maskowh:feature/update-check-users-follow-playlist-endpoint
Apr 18, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to match the updated endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
============================================
- Coverage 66.39% 66.33% -0.07%
Complexity 669 669
============================================
Files 184 184
Lines 7107 7111 +4
Branches 1146 1146
============================================
- Hits 4719 4717 -2
- Misses 1483 1491 +8
+ Partials 905 903 -2 ☔ View full report in Codecov by Sentry. |
dargmuesli
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 💚
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Apr 21, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | debian | final | digest | `ccb33c3` -> `3d5df92` | | | | | | maven | stage | digest | `3a69a5d` -> `d1412a5` | | | | | | rust | stage | patch | `1.77.1-bookworm` -> `1.77.2-bookworm` | [![age](https://developer.mend.io/api/mc/badges/age/docker/rust/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/rust/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/rust/1.77.1/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/rust/1.77.1/1.77.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [se.michaelthelin.spotify:spotify-web-api-java](https://togithub.com/spotify-web-api-java/spotify-web-api-java) | compile | minor | `8.3.6` -> `8.4.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/se.michaelthelin.spotify:spotify-web-api-java/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/se.michaelthelin.spotify:spotify-web-api-java/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/se.michaelthelin.spotify:spotify-web-api-java/8.3.6/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/se.michaelthelin.spotify:spotify-web-api-java/8.3.6/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://togithub.com/spring-projects/spring-boot)) | parent | patch | `3.2.4` -> `3.2.5` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.springframework.boot:spring-boot-starter-parent/3.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.springframework.boot:spring-boot-starter-parent/3.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.springframework.boot:spring-boot-starter-parent/3.2.4/3.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.springframework.boot:spring-boot-starter-parent/3.2.4/3.2.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>spotify-web-api-java/spotify-web-api-java (se.michaelthelin.spotify:spotify-web-api-java)</summary> ### [`v8.4.0`](https://togithub.com/spotify-web-api-java/spotify-web-api-java/releases/tag/8.4.0) [Compare Source](https://togithub.com/spotify-web-api-java/spotify-web-api-java/compare/8.3.6...8.4.0) #### What's Changed - Deprecate usage of owner_id param in CheckUsersFollowPlaylist requests to match the updated endpoint by [@​Maskowh](https://togithub.com/Maskowh) in [https://github.com/spotify-web-api-java/spotify-web-api-java/pull/397](https://togithub.com/spotify-web-api-java/spotify-web-api-java/pull/397) #### New Contributors - [@​Maskowh](https://togithub.com/Maskowh) made their first contribution in [https://github.com/spotify-web-api-java/spotify-web-api-java/pull/397](https://togithub.com/spotify-web-api-java/spotify-web-api-java/pull/397) **Full Changelog**: spotify-web-api-java/spotify-web-api-java@8.3.6...8.4.0 </details> <details> <summary>spring-projects/spring-boot (org.springframework.boot:spring-boot-starter-parent)</summary> ### [`v3.2.5`](https://togithub.com/spring-projects/spring-boot/compare/v3.2.4...v3.2.5) [Compare Source](https://togithub.com/spring-projects/spring-boot/compare/v3.2.4...v3.2.5) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #395 , this is a pull request linked to #396 that removes the usage of the
owner_id
param in CheckUsersFollowPlaylist requests since it is no longer in documentation and might break in the futur. The methods usingowner_id
param are now deprecated, allowing users to update their codes before removal.