Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify maven version requirements in readme and cleanup antrun output #940

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Clarify maven version requirements in readme and cleanup antrun output #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55b3ac6
[pom] Remove antrun version definition as defined by base-parent
hazendaz Nov 29, 2024
80ae1ed
[pom] While still using antrun, make sure messages that are debug lev…
hazendaz Nov 29, 2024
b71e097
[ci] Make sure readme for gui reflects current 4.8.6.6
hazendaz Nov 29, 2024
e8c96fc
[ci] Add note on what maven is required to build and what is required…
hazendaz Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Building spotbugs-maven-plugin Requirements
===========================================

Java 17+ is required to build the project. Java 8+ is required for spotbugs analysis.
Maven 3.9.9 is required to build the project. It can be used as low as maven 3.6.3 in usage.

spotbugs-maven-plugin
=====================
Expand Down Expand Up @@ -61,7 +62,7 @@ mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspe

Run gui with a specific version
```
mvn com.github.spotbugs:spotbugs-maven-plugin:4.8.6.2:gui
mvn com.github.spotbugs:spotbugs-maven-plugin:4.8.6.6:gui
```

## Creating new site examples ##
Expand Down
12 changes: 5 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,6 @@
<plexusUtilsVersion>4.0.2</plexusUtilsVersion>
<plexusXmlVersion>3.0.1</plexusXmlVersion>

<antrunPluginVersion>3.1.0</antrunPluginVersion>
<l10nPluginVersion>1.1.0</l10nPluginVersion>
<codenarcPluginVersion>0.22-1</codenarcPluginVersion>
<gmavenPluginVersion>4.0.1</gmavenPluginVersion>
Expand Down Expand Up @@ -993,7 +992,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
<version>${antrunPluginVersion}</version>
<executions>
<execution>
<id>prepare-integration-test-local-spotbugs-src</id>
Expand All @@ -1003,12 +1001,12 @@
<phase>pre-integration-test</phase>
<configuration>
<target>
<echo>Copying Source for Tests......</echo>
<echo>Making ${integrationTestSrc}</echo>
<echo level="debug">Copying Source for Tests......</echo>
<echo level="debug">Making ${integrationTestSrc}</echo>
<mkdir dir="${integrationTestSrc}" />
<echo>Copying to ${integrationTestSrc}</echo>
<echo>from ${localTestSrc}</echo>
<echo>for ${includesTestSrcPattern}</echo>
<echo level="debug">Copying to ${integrationTestSrc}</echo>
<echo level="debug">from ${localTestSrc}</echo>
<echo level="debug">for ${includesTestSrcPattern}</echo>
<copy todir="${integrationTestSrc}">
<fileset dir="${localTestSrc}" includes="${includesTestSrcPattern}" />
</copy>
Expand Down
Loading