Make sarifOutputDirectory and sarifOutputFilename configurable #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwgmeligmeyling
force-pushed
the
issues/506-507
branch
from
c89881e
to
ac3bb58
Compare
jwgmeligmeyling
force-pushed
the
issues/506-507
branch
from
ac3bb58
to
e148e19
Compare
|
@jwgmeligmeyling The force file happens earlier, is it needed to happen there as well? Seems like its happening twice with this change. The first call happens already right after the point you use the new parameters added here. Few lines below. |
|
The other forceFile only happens on the temporary file location, not the resultFile. The resultFile relied on the forceFile(temporaryResult) to create the parent folders, but with this change these folders may now differ. I actually amended it to my copy later when I noticed it wasn't working. |
|
Totally missed that key difference. Thanks. Will get this merged in and a release sometime this weekend.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jan-Willem Gmelig Meyling ***@***.***>
Sent: Saturday, November 5, 2022 9:49:43 AM
To: spotbugs/spotbugs-maven-plugin ***@***.***>
Cc: Jeremy Landis ***@***.***>; Comment ***@***.***>
Subject: Re: [spotbugs/spotbugs-maven-plugin] Make sarifOutputDirectory and sarifOutputFilename configurable (PR #508)
The other forceFile only happens on the temporary file location, not the resultFile. The resultFile relied on the forceFile(temporaryResult) to create the parent folders, but with this change these folders may now differ. I actually amended it to my copy later when I noticed it wasn't working.
—
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fspotbugs%2Fspotbugs-maven-plugin%2Fpull%2F508%23issuecomment-1304550215&data=05%7C01%7C%7C3eefa1030f6142e285cc08dabf3498b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638032529872027860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=66s9Q5VYvAZ%2Fk6ujlvZifS4WgyxPdcK2gRQyk%2FB3rFI%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHODIY72AGOWLENAEYCYJ3WGZQXPANCNFSM6AAAAAARWQHIVU&data=05%7C01%7C%7C3eefa1030f6142e285cc08dabf3498b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638032529872184114%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=KPEM3gM5%2FWlzbpE9pzBVAKejk0%2B%2BmAkfElH1U6b0whM%3D&reserved=0>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
@jwgmeligmeyling This has been released as 4.7.2.2 now. |
|
Thanks! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #506
Fixes #507