Merge pull request #190 from hazendaz/spotbugs

HTML5 cleanup of site / formatting / note about version 4.0 upcoming release
spotbugs · Mar 14, 2020 · 8700eea · 8700eea
2 parents f3da766 + 487afd6
commit 8700eea
Show file tree

Hide file tree

Showing 207 changed files with 1,739 additions and 1,657 deletions.
diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *      http://www.apache.org/licenses/LICENSE-2.0
+ *      https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/LICENSE b/LICENSE
@@ -1,7 +1,7 @@
 
                                  Apache License
                            Version 2.0, January 2004
-                        http://www.apache.org/licenses/
+                        https://www.apache.org/licenses/
 
    TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
 
@@ -193,7 +193,7 @@
    you may not use this file except in compliance with the License.
    You may obtain a copy of the License at
 
-       http://www.apache.org/licenses/LICENSE-2.0
+       https://www.apache.org/licenses/LICENSE-2.0
 
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/mvnw b/mvnw
@@ -8,7 +8,7 @@
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
 #
-#    http://www.apache.org/licenses/LICENSE-2.0
+#    https://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing,
 # software distributed under the License is distributed on an

diff --git a/mvnw.cmd b/mvnw.cmd
@@ -7,7 +7,7 @@
 @REM "License"); you may not use this file except in compliance
 @REM with the License.  You may obtain a copy of the License at
 @REM
-@REM    http://www.apache.org/licenses/LICENSE-2.0
+@REM    https://www.apache.org/licenses/LICENSE-2.0
 @REM
 @REM Unless required by applicable law or agreed to in writing,
 @REM software distributed under the License is distributed on an

diff --git a/pom.xml b/pom.xml
@@ -77,7 +77,7 @@
       <name>Rolf Kulemann</name>
       <email>[email protected]</email>
       <organization>NEO Business Partners</organization>
-      <organizationUrl>http://www.neo-partners.com</organizationUrl>
+      <organizationUrl>https://www.axians.de/de/portfolio/sap-solutions-technology/</organizationUrl>
       <roles>
         <role>Java Developer</role>
       </roles>

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -6,6 +6,11 @@
     </author>
   </properties>
   <body>
+    <release version="4.0.0" date="in Github" description="Released support for spotbugs 4.0">
+        <action dev="jwl" type="update">
+            Releasing support for spot bugs 4.0
+        </action>
+    </release>
     <release version="3.1.0" date="in GitHub" description="Rebrand and upgrade using Spotbugs">
         <action dev="jwl" type="update">
             Rebrand and upgrade to using spotbugs

diff --git a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java
@@ -21,4 +21,4 @@ void thisAlwaysPasses() {
     public void thisIsIgnored() {
         // Do nothing
     }
-}
+}
diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/src/it-tools/build-tools/verify.groovy b/src/it-tools/build-tools/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -15,4 +15,3 @@
  */
 
 assert new File(basedir, 'target/build-tools-testing.jar').exists()
-
diff --git a/src/it-tools/prime/pom.xml b/src/it-tools/prime/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml b/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml
@@ -3,4 +3,4 @@
   <Match>
     <Bug pattern="DMI_INVOKING_TOSTRING_ON_ARRAY"/>
   </Match>
-</FindBugsFilter>
+</FindBugsFilter>
diff --git a/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml b/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml
@@ -3,4 +3,4 @@
   <Match>
     <Bug pattern="DLS_DEAD_LOCAL_STORE"/>
   </Match>
-</FindBugsFilter>
+</FindBugsFilter>
diff --git a/src/it-tools/prime/verify.groovy b/src/it-tools/prime/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -15,4 +15,3 @@
  */
 
 assert new File(basedir, 'target/prime-testing.jar').exists()
-
diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -66,4 +66,4 @@
       </plugin>
     </plugins>
   </reporting>
-</project>
+</project>
diff --git a/src/it/basic-1/pom.xml b/src/it/basic-1/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -46,4 +46,4 @@
       </plugin>
     </plugins>
   </reporting>
-</project>
+</project>
diff --git a/src/it/basic-1/verify.groovy b/src/it/basic-1/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}"
 assert xdocErrors == spotbugsXmlErrors
 
 assert spotbugsErrors == spotbugsXmlErrors
-
diff --git a/src/it/change-xml-filename/pom.xml b/src/it/change-xml-filename/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/src/it/change-xml-filename/verify.groovy b/src/it/change-xml-filename/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -32,4 +32,3 @@ println "BugInstance size is ${spotbugsXmlErrors}"
 
 
 assert spotbugsXmlErrors > 0
-
diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -41,4 +41,4 @@
       </plugin>
     </plugins>
   </build>
-</project>
+</project>
diff --git a/src/it/check-jvmargs/pom.xml b/src/it/check-jvmargs/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -43,4 +43,4 @@
       </plugin>
     </plugins>
   </build>
-</project>
+</project>
diff --git a/src/it/check-jvmargs/verify.groovy b/src/it/check-jvmargs/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -44,4 +44,3 @@ def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 
 assert xdocErrors == spotbugsXmlErrors
-
diff --git a/src/it/check-multi/modules/module-1/pom.xml b/src/it/check-multi/modules/module-1/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -27,4 +27,4 @@
   <artifactId>module-1</artifactId>
   <name>module-1</name>
   <packaging>jar</packaging>
-</project>
+</project>
diff --git a/src/it/check-multi/modules/module-2/pom.xml b/src/it/check-multi/modules/module-2/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -27,4 +27,4 @@
   <artifactId>module-2</artifactId>
   <name>module-2</name>
   <packaging>jar</packaging>
-</project>
+</project>
diff --git a/src/it/check-multi/modules/pom.xml b/src/it/check-multi/modules/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -61,4 +61,4 @@
     <module>module-1</module>
     <module>module-2</module>
   </modules>
-</project>
+</project>
diff --git a/src/it/check-multi/pom.xml b/src/it/check-multi/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -29,4 +29,4 @@
   <modules>
     <module>modules</module>
   </modules>
-</project>
+</project>
diff --git a/src/it/check-multi/verify.groovy b/src/it/check-multi/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -41,4 +41,4 @@
       </plugin>
     </plugins>
   </build>
-</project>
+</project>
diff --git a/src/it/check-pluginList-repo/pom.xml b/src/it/check-pluginList-repo/pom.xml
@@ -2,7 +2,7 @@
 <!-- Copyright (C) 2006-2020 the original author or authors. Licensed under 
   the Apache License, Version 2.0 (the "License"); you may not use this file 
   except in compliance with the License. You may obtain a copy of the License 
-  at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable 
+  at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable 
   law or agreed to in writing, software distributed under the License is distributed 
   on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
   express or implied. See the License for the specific language governing permissions 
@@ -45,4 +45,4 @@
       </plugin>
     </plugins>
   </build>
-</project>
+</project>
diff --git a/src/it/check-pluginList-repo/verify.groovy b/src/it/check-pluginList-repo/verify.groovy
@@ -5,7 +5,7 @@
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
  *
- *     http://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
@@ -45,4 +45,3 @@ def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size()
 println "BugInstance size is ${xdocErrors}"
 
 assert xdocErrors == spotbugsXmlErrors
-
diff --git a/src/it/check-skip/pom.xml b/src/it/check-skip/pom.xml
@@ -6,7 +6,7 @@
     you may not use this file except in compliance with the License.
     You may obtain a copy of the License at
 
-        http://www.apache.org/licenses/LICENSE-2.0
+        https://www.apache.org/licenses/LICENSE-2.0
 
     Unless required by applicable law or agreed to in writing, software
     distributed under the License is distributed on an "AS IS" BASIS,
@@ -42,4 +42,4 @@
       </plugin>
     </plugins>
   </build>
-</project>
+</project>
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,4 +21,4 @@ void thisAlwaysPasses() { @@
         public void thisIsIgnored() {
             // Do nothing
         }
-    }
+    }