Merge pull request #471 from hazendaz/spotbugs

Adjustments for jdk 17 site building and few formatting items

.github/workflows/coveralls.yaml

@@ -27,7 +27,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: 'zulu'
       - name: Report Coverage to Coveralls for Pull Requests
         if: github.event_name == 'pull_request'

.github/workflows/coverity.yaml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: 'zulu'
       - name: Analyze with Coverity
         run: |

.github/workflows/it.yaml

@@ -30,7 +30,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: 'zulu'
       - name: Build Setup
         run: ./mvnw clean install

.github/workflows/site.yaml

@@ -14,7 +14,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 11
+          java-version: 17
           distribution: 'zulu'
       - uses: webfactory/ssh-agent@master
         with:

.mvn/jvm.config

@@ -1 +1 @@
--XX:+TieredCompilation -XX:TieredStopAtLevel=1
+-XX:+TieredCompilation -XX:TieredStopAtLevel=1 --add-opens=java.base/java.io=ALL-UNNAMED

pom.xml

@@ -149,7 +149,7 @@
     <!-- Override spotbugs to this version from base-parent -->
     <spotbugs.version>4.7.1</spotbugs.version>
 
-    <!-- Groovy doesn't like simple '8' for java 8 -->
+    <!-- Groovymavenplus doesn't like simple '8' for java 8 until next release -->
     <java.version>1.8</java.version>
 
     <junitVersion>5.9.0-RC1</junitVersion>

src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy

@@ -527,7 +527,8 @@ abstract class BaseViolationCheckMojo extends AbstractMojo {
                 def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK +
                         bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type'
 
-                if (priorityNum <= priorityThresholdNum) {  // lower is more severe
+                // lower is more severe
+                if (priorityNum <= priorityThresholdNum) {
                     bugCountAboveThreshold += 1
                     log.error(logMsg)
                 } else {
@@ -537,7 +538,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo {
 
             log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n')
 
-            if ( (bugCountAboveThreshold || errorCount) && failOnError ) {
+            if ((bugCountAboveThreshold || errorCount) && failOnError) {
                 throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ")
             }
         }