fix: stop printing stacktraces by default when ignoreFailures = true

make changes from #266 enable by default BREAKING CHANGE: stacktraces is not printed by default when `ignoreFailures = true`. set `showStackTraces = true` explicitly if necessary.
spotbugs · Oct 7, 2021 · e739a30 · e739a30
1 parent 8cb962b
commit e739a30
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/functionalTest/groovy/com/github/spotbugs/snom/StandardFunctionalTest.groovy b/src/functionalTest/groovy/com/github/spotbugs/snom/StandardFunctionalTest.groovy
@@ -251,6 +251,7 @@ spotbugsMain {
         buildFile << """
 spotbugs {
     ignoreFailures = true
+    showStackTraces = true
 }"""
         when:
         def arguments = [':spotbugsMain', '-is']

diff --git a/src/main/groovy/com/github/spotbugs/snom/SpotBugsExtension.groovy b/src/main/groovy/com/github/spotbugs/snom/SpotBugsExtension.groovy
@@ -162,7 +162,7 @@ class SpotBugsExtension {
     @Inject
     SpotBugsExtension(Project project, ObjectFactory objects) {
         ignoreFailures = objects.property(Boolean).convention(false);
-        showStackTraces = objects.property(Boolean).convention(true);
+        showStackTraces = objects.property(Boolean).convention(false);
         showProgress = objects.property(Boolean);
         reportLevel = objects.property(Confidence);
         effort = objects.property(Effort);

diff --git a/src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsRunnerForWorker.java b/src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsRunnerForWorker.java
@@ -129,7 +129,7 @@ public void execute() {
 
             if (params.getIgnoreFailures().getOrElse(Boolean.FALSE).booleanValue()) {
               log.warn(message.toString());
-              if (params.getShowStackTraces().getOrElse(Boolean.TRUE).booleanValue()) {
+              if (params.getShowStackTraces().getOrElse(Boolean.FALSE).booleanValue()) {
                 log.warn("", e);
               }
             } else {