feat: Add functional tests for Android libraries as well

spotbugs · Jun 2, 2020 · 16200b2 · 16200b2
1 parent 50156ee
commit 16200b2
Showing 1 changed file with 91 additions and 7 deletions.
diff --git a/src/functionalTest/groovy/com/github/spotbugs/snom/AndroidFunctionalTest.groovy b/src/functionalTest/groovy/com/github/spotbugs/snom/AndroidFunctionalTest.groovy
@@ -41,10 +41,10 @@ class AndroidFunctionalTest extends Specification {
     }
 
     @Requires({env['ANDROID_SDK_ROOT']})
-    def "can generate spotbugsRelease depending on variant compilation task with AGP 3.5.3"() {
+    def "can generate spotbugsRelease depending on app variant compilation task with AGP 3.5.3"() {
         given: "a Gradle project to build an Android app"
         GradleRunner runner = getGradleRunner()
-        writeBuildFile(runner, '3.5.3')
+        writeAppBuildFile(runner, '3.5.3')
         writeSourceFile()
         writeManifestFile()
 
@@ -56,10 +56,25 @@ class AndroidFunctionalTest extends Specification {
     }
 
     @Requires({env['ANDROID_SDK_ROOT']})
-    def "can generate spotbugsRelease depending on variant compilation task with AGP 3.6.3"() {
+    def "can generate spotbugsRelease depending on library variant compilation task with AGP 3.5.3"() {
+        given: "a Gradle project to build an Android library"
+        GradleRunner runner = getGradleRunner()
+        writeLibraryBuildFile(runner, '3.5.3')
+        writeSourceFile()
+        writeManifestFile()
+
+        when: "the spotbugsRelease task is executed"
+        BuildResult result = build(runner)
+
+        then: "gradle runs spotbugsRelease successfully"
+        assertEquals(SUCCESS, result.task(":spotbugsRelease").outcome)
+    }
+
+    @Requires({env['ANDROID_SDK_ROOT']})
+    def "can generate spotbugsRelease depending on app variant compilation task with AGP 3.6.3"() {
         given: "a Gradle project to build an Android app"
         GradleRunner runner = getGradleRunner()
-        writeBuildFile(runner, '3.6.3')
+        writeAppBuildFile(runner, '3.6.3')
         writeSourceFile()
         writeManifestFile()
 
@@ -71,13 +86,46 @@ class AndroidFunctionalTest extends Specification {
     }
 
     @Requires({env['ANDROID_SDK_ROOT']})
-    def "can generate spotbugsRelease depending on variant compilation task with AGP 4.0.0"() {
+    def "can generate spotbugsRelease depending on library variant compilation task with AGP 3.6.3"() {
+        given: "a Gradle project to build an Android library"
+        GradleRunner runner = getGradleRunner()
+        writeLibraryBuildFile(runner, '3.6.3')
+        writeSourceFile()
+        writeManifestFile()
+
+        when: "the spotbugsRelease task is executed"
+        BuildResult result = build(runner)
+
+        then: "gradle runs spotbugsRelease successfully"
+        assertEquals(SUCCESS, result.task(":spotbugsRelease").outcome)
+    }
+
+    @Requires({env['ANDROID_SDK_ROOT']})
+    def "can generate spotbugsRelease depending on app variant compilation task with AGP 4.0.0"() {
         assumeTrue("AGP 4.0.0 is only supported by Gradle 6.1.1 and up",
                 GradleVersion.version(version) >= GradleVersion.version("6.1.1"))
 
         given: "a Gradle project to build an Android app"
         GradleRunner runner = getGradleRunner()
-        writeBuildFile(runner, '4.0.0')
+        writeAppBuildFile(runner, '4.0.0')
+        writeSourceFile()
+        writeManifestFile()
+
+        when: "the spotbugsRelease task is executed"
+        BuildResult result = build(runner)
+
+        then: "gradle runs spotbugsRelease successfully"
+        assertEquals(SUCCESS, result.task(":spotbugsRelease").outcome)
+    }
+
+    @Requires({env['ANDROID_SDK_ROOT']})
+    def "can generate spotbugsRelease depending on library variant compilation task with AGP 4.0.0"() {
+        assumeTrue("AGP 4.0.0 is only supported by Gradle 6.1.1 and up",
+                GradleVersion.version(version) >= GradleVersion.version("6.1.1"))
+
+        given: "a Gradle project to build an Android library"
+        GradleRunner runner = getGradleRunner()
+        writeLibraryBuildFile(runner, '4.0.0')
         writeSourceFile()
         writeManifestFile()
 
@@ -104,7 +152,7 @@ class AndroidFunctionalTest extends Specification {
         runner
     }
 
-    def writeBuildFile(runner, agpVersion) {
+    def writeAppBuildFile(runner, agpVersion) {
         File buildFile = new File(rootDir, 'build.gradle')
         buildFile << """
 buildscript {
@@ -145,6 +193,42 @@ android {
 """
     }
 
+    def writeLibraryBuildFile(runner, agpVersion) {
+        File buildFile = new File(rootDir, 'build.gradle')
+        buildFile << """
+buildscript {
+    repositories {
+        google()
+        jcenter()
+    }
+
+    dependencies {
+        classpath 'com.android.tools.build:gradle:$agpVersion'
+"""
+        runner.pluginClasspath.forEach({ file ->
+            buildFile << """
+        classpath files('${file.absolutePath}')
+"""
+        })
+        buildFile << """
+    }
+}
+
+apply plugin: 'com.android.library'
+apply plugin: 'com.github.spotbugs'
+
+repositories {
+    google()
+    jcenter()
+}
+
+android {
+    compileSdkVersion 29
+    buildToolsVersion '29.0.2'
+}
+"""
+    }
+
     void writeSourceFile() {
         File sourceFile = new File(rootDir, "src/main/java/Foo.java")
         sourceFile.parentFile.mkdirs()