Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported namespaces #618

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Supported namespaces #618

merged 3 commits into from
Aug 16, 2023

Conversation

hashemi-soroush
Copy link
Contributor

Fixes #617

Changes proposed on the PR:

  • Adds a new optional CLI argument named supported-namespaces-regex, defaulted to .*
  • Panics at startup if the regex doesn't compile
  • Adds the filtering logic to the Retriever

@hashemi-soroush hashemi-soroush requested a review from a team as a code owner June 12, 2023 14:37
@ese ese merged commit f32faf0 into spotahome:master Aug 16, 2023
@ese
Copy link
Member

ese commented Aug 16, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese ese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter watched namespaces
2 participants
@hashemi-soroush @ese