Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support volumeCliamTemplates #61

Closed
wants to merge 2 commits into from
Closed

Conversation

sillydong
Copy link
Contributor

add volumes, volumeMounts, volumeClaimTemplates
remove dataVolume

Fixes # .

Changes proposed on the PR:

  • add more configuration for redis store

@sillydong sillydong requested review from ese, jchanam and slok as code owners May 29, 2018 07:12
@sillydong
Copy link
Contributor Author

We met a demand to use PersistentVolumeClaim in redis store, so I added more configuration for this demand.

PS: dataVolume is removed as there is no need for dataVolume, I add volumes for it.

@sillydong
Copy link
Contributor Author

If there is anything wrong, please tell me. Thanks! @jchanam

@sillydong sillydong mentioned this pull request Jul 13, 2018
@jchanam
Copy link
Collaborator

jchanam commented Jul 16, 2018

Hi @sillydong,

First of all, sorry for the delay.

The point of having the Custom Resource, is making the creation of a Redis as easy as possible. I think doing this the way you're proposing, is maybe adding much complexity.

I'd do it less configurable. Basically, allowing having an empty-dir (by default), or a Persistent Volume Claim.

What do you think? As this is becoming a priority for us, we have been thinking on developing this functionality. Would you mind if I develop it and send a PR?

Thanks again for your interest!

@sillydong
Copy link
Contributor Author

Great, hoping we can use it soon!

@ese
Copy link
Member

ese commented Jul 18, 2018

closed in favor of #68

@ese ese closed this Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants