Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sentinel readiness probe to fail when monitoring localhost #588

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

ese
Copy link
Member

@ese ese commented Apr 20, 2023

Original PR: #558
Fixes #532 .

Changes proposed on the PR:

  • Readiness check for sentinel shall fail when it doesn't monitor the right master, at least when we know that it monitors the wrong one which is 127.0.0.1
  • There'll be dependency on grep and head existing on the redis image used for sentinels. I tested alpine and bullseye in the official redis images here and they worked as expected.

I think we should have customised readiness and liveness checks in the future as well but for now this should be enough.

@ese ese merged commit 432661f into master Apr 20, 2023
@ese ese deleted the zekena2/master branch April 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentinel Readiness is ready when really not
1 participant