Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Adding capabilility to define custom probes #560

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Feature: Adding capabilility to define custom probes #560

merged 7 commits into from
Apr 20, 2023

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Feb 4, 2023

Feature: Custom Probes

Both Redis and Sentinel will have the capability to now define...

  • customLivenessProbe: Your own Liveness probe
  • customReadinessProbe: Your own Readiness probe
  • customStartupProbe: Your own Startup probe

@samof76 samof76 requested a review from a team as a code owner February 4, 2023 02:56
@samof76 samof76 closed this Feb 15, 2023
@samof76 samof76 reopened this Feb 15, 2023
@samof76
Copy link
Contributor Author

samof76 commented Feb 19, 2023

@ese can you please review this?

@samof76
Copy link
Contributor Author

samof76 commented Feb 20, 2023

@ese a couple of things I have done fix...
... 1. The issue of the alpha fields.
Downgraded k8s.io/api and k8s.io/apimachinery

go get -v k8s.io/[email protected]
go get k8s.io/[email protected]
go mod tidy
go mod vendor

And then generated CRD file.

... 2. The minikube new version has an issue with the cni plugin so downgraded it, as well.

@samof76
Copy link
Contributor Author

samof76 commented Mar 5, 2023

@ese please review this?

@ese ese merged commit c51fa70 into spotahome:master Apr 20, 2023
@jonathon2nd jonathon2nd mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese ese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samof76 @ese