Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]add rf Annotations to sts #495

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 12, 2022

Fixes # .
The annotations for CR resources are usually carried over to the main working resources. This is because sometimes other operator operations need to recognise specific annotations. redis-operator now has no such entry point to inject specific annotations.
Changes proposed on the PR:

  • Provide an entry point to inject annotations into work resources。

@jiuker jiuker requested a review from a team as a code owner October 12, 2022 06:13
@jiuker jiuker closed this Oct 13, 2022
@jiuker jiuker reopened this Oct 21, 2022
service/k8s/statefulset.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from samof76 November 22, 2022 07:57
@jiuker jiuker changed the title add rf Annotations to sts [feature]add rf Annotations to sts Nov 22, 2022
@ese
Copy link
Member

ese commented Nov 22, 2022

Thanks @jiuker

@ese ese merged commit 243ff47 into spotahome:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants