-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metrics #490
Add Metrics #490
Conversation
Redis failover health dashboardGives details around various aspect for a given redisfailover CR aka "tenant", from the operator's perspective. json of the dashboard: link |
@raghu-nandan-bs looks good. Is this still WIP? |
Great! Thanks. I'm ok with it, just check the CI jobs since seems to be some deadcode. |
…ecord each operation as success / fail
…dis-operator into feat/add-metrics
…ics; donot return errors.
@ese please review this. This looks good, and will add a lot of value to the prod deployments. |
@ese all the checks seemed to have passed, can this be merged? |
Thank you so much! |
@ese thanks for merging this... Shortly, I will share a small change to GC stale metrics and updated dashboard. |
Hi @jonathon2nd really sorry for that, I will share an updated dashboard today. Also, which version of grafana are you on? the error seems to be something different |
I am using what is built into Rancher monitoring. Grafana v7.5.11 is what it is using. |
Hi @jonathon2nd please try this and let me know if it works.. https://github.com/raghu-nandan-bs/redis-operator/blob/fix/recycle-stale-metrics/example/grafana-dashboard/redisfailover-health.json |
@jonathon2nd I created this dashboard on |
I am looking to see about upgrading the grafana image that is part of the Rancher Monitoring stack. |
Fixes #
Changes proposed on the PR:
Metrics
example: