Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate Exporter Struct #463

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Deduplicate Exporter Struct #463

merged 2 commits into from
Sep 5, 2022

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Sep 5, 2022

Fixes #000 .

Changes proposed on the PR:

  • Remove RedisExporter and SentinelExporter struct created Exporter struct
  • Create deep copy using update-codegen
  • Change the CRDs to reflect these changes

@samof76 samof76 requested a review from a team as a code owner September 5, 2022 07:01
@ese ese merged commit 8992fae into spotahome:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese ese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samof76 @ese