Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidecars and initcontainers #435

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Add sidecars and initcontainers #435

merged 5 commits into from
Aug 31, 2022

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Aug 22, 2022

Fixes #187

Changes proposed on the PR:

  • Adds sidecar
  • Adds initcontainer

@samof76 samof76 requested a review from ese as a code owner August 22, 2022 10:49
@ese
Copy link
Member

ese commented Aug 24, 2022

Thanks @samof76, what is the use case you are trying to resolve with this feature? It could be something that we should abstract and manage directly from the operator.
Anyways I'm not against the feature but I would name the sidecars property as extraContainers

@samof76
Copy link
Contributor Author

samof76 commented Aug 25, 2022

We require addition containers for

  • manage failover to be propagated to the DNS
  • manage periodic backup of the RDB files to blob storages
  • Some other additional tasks

@samof76
Copy link
Contributor Author

samof76 commented Aug 25, 2022

@ese sidecars -> extraContainers

@ese
Copy link
Member

ese commented Aug 30, 2022

Thanks @samof76, could you resolve conflicts and generate CRDs with changed spec?

@ese ese merged commit fa8c5b9 into spotahome:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add sidecar container in redis-data-rfr-redisfailover pod
2 participants