Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopologySpreadContraints, Custom Port, Ping User and Kustomize Examples #429

Closed
wants to merge 1 commit into from
Closed

TopologySpreadContraints, Custom Port, Ping User and Kustomize Examples #429

wants to merge 1 commit into from

Conversation

samof76
Copy link
Contributor

@samof76 samof76 commented Aug 18, 2022

Fixes #412 : Adding a pinger user with pingpass with only ping permission and use this user for liveness probes
Fixes #370 : Adding custom port changes for we have use case where in the migrating to redis on k8s does not require any application, config changes
Features

  • Added topologySpreadContraints for even distribution of pods
  • Added Kustomize examples for deployments with overlays

@samof76
TopologySpreadContraints, Custom Port, Ping User (#1)
cfe9d38 
* Fixing tests

* Create my branch

* WIP: Changes to makefile

* WIP: Update the redis-exporter images

* Pass the right shutdown command

* Adding the containersecuritycontext

* WIP: Add topologySpreadConstraints

* WIP: TopologySpreadConstraints

* WIP: Port changes

* WIP: Port change

* WIP: Adding port to readiness script

* WIP: New deployment

* WIP: Port changes

* WIP: Port change liveness and exporter

* WIP: Ensure port is passed

* WIP: Updated the image reference

* WIP: Residual comment

* Making PR Ready(WIP)
@samof76 samof76 requested a review from ese as a code owner August 18, 2022 09:12
@samof76
Copy link
Contributor Author

samof76 commented Aug 19, 2022

Justification for Custom Port Support @ese

In a multitenant model, where in the you are basically running redis as a service for the consumption, we would want to restrict at the security group level who is allowed to connect to a tenant's redis, and if we use the standard port 6379 we would exposing all redis installation to all tenants. With custom port we could restrict at the security group level who has access to the a particular redis.

@samof76
Copy link
Contributor Author

samof76 commented Aug 19, 2022

@ese

Sent seperate PRs #430 and #431 will send one separately for the custom port.

@samof76
Copy link
Contributor Author

samof76 commented Aug 19, 2022

@ese Will close this PR once you have merged #434 #433 #432 #431 #430

@samof76
Copy link
Contributor Author

samof76 commented Aug 31, 2022

@ese closing this as the these changes have been merge through other PRs. Thanks!

@samof76 samof76 closed this Aug 31, 2022
@ese
Copy link
Member

ese commented Aug 31, 2022 •
edited
Loading

Thanks @samof76 ! I just published a release candidate https://github.com/spotahome/redis-operator/releases/tag/v1.2.0-rc0
It would be great if you can do some kind of testing to report if there is any bug before the final release

docker pull quay.io/spotahome/redis-operator:v1.2.0-rc0

@samof76 samof76 mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese Awaiting requested review from ese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubelet Readiness probe failed: Change Redis pods exposed port
2 participants
@samof76 @ese