Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown script environment variable fix #372

Merged
merged 2 commits into from
Feb 16, 2022
Merged

shutdown script environment variable fix #372

merged 2 commits into from
Feb 16, 2022

Conversation

zekena2
Copy link

@zekena2 zekena2 commented Feb 13, 2022

Changes proposed on the PR:

  • makes the env variables of the shutdown script correct according to what's inside the container
  • I checked what variables are inside the redis containers with printenv and didn't find any variable with RFS_REDIS_* but found instead of REDIS the failover name with capital letters
  • something else I found that all variables belong to other failovers are inside the container for some reason.

@zekena2 zekena2 requested a review from ese as a code owner February 13, 2022 08:54
ese
ese reviewed Feb 16, 2022
View reviewed changes
Copy link
Member

@ese ese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @zekena2 Thanks!

@ese ese merged commit 494cb8a into spotahome:master Feb 16, 2022
@JorTurFer JorTurFer mentioned this pull request Mar 17, 2022
Closed
@mariusstaicu mariusstaicu mentioned this pull request Jul 6, 2022
Closed
@mariusstaicu
Copy link

@ese when is the next release planned, the one that will contain this fix ?

@samof76
Copy link
Contributor

samof76 commented Aug 30, 2022

@zekena2 this too is need... #433

@leejones leejones mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese ese left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zekena2 @mariusstaicu @samof76 @ese