New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use net.JoinHostPort() to support connection to redis pod in IPv6 k8s cluster #369

Merged

ese merged 3 commits into spotahome:master from wning-vmware:master

Feb 7, 2022

Contributor

wning-vmware commented Feb 7, 2022

Fixes #279.

Changes proposed on the PR:

As per https://pkg.go.dev/net#JoinHostPort, JoinHostPort combines host and port into a network address of the form "host:port". If host contains a colon, as found in literal IPv6 addresses, then JoinHostPort returns "[host]:port".


          Use net.JoinHostPort() to support connection to redis pod in IPv6 k8s…

aa63861

… cluster

wning-vmware requested a review from ese as a code owner

February 7, 2022 08:36


          Fix golang check

e8b7b8a

Member

ese commented Feb 7, 2022 •

edited

Loading

Thanks for the PR, you can fix the formatting issue with gofmt -w service/redis/client.go


          Fixed formatting issue with gofmt -w service/redis/client.go

52358c0

ese approved these changes

View reviewed changes

ese merged commit 22e0631 into spotahome:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet