Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add containers securityContext management from crd definition v… #314

Merged
merged 4 commits into from
Feb 16, 2022
Merged

feat: add containers securityContext management from crd definition v… #314

merged 4 commits into from
Feb 16, 2022

Conversation

MatthieuFin
Copy link
Contributor

Add a containerSecurityContext fields support in RedisFailover object for all containers, which permit to customize securityContext for containers and initContainers.
With following default securityContext for each containers:

    securityContext:
      allowPrivilegeEscalation: false
      capabilities:
        drop:
        - ALL
      privileged: false
      readOnlyRootFilesystem: true
      runAsGroup: 1000
      runAsNonRoot: true
      runAsUser: 1000

@MatthieuFin MatthieuFin requested a review from ese as a code owner June 11, 2021 15:35
@ese
Copy link
Member

ese commented Jan 12, 2022

@MatthieuFin LGTM, sorry for late response. Would you mind rebasing with master?

@ese
Copy link
Member

ese commented Feb 16, 2022

Thanks @MatthieuFin

@ese ese merged commit 6e08a31 into spotahome:master Feb 16, 2022
@samof76 samof76 mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese Awaiting requested review from ese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthieuFin @ese