Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change to release v1.0.0-rc.4 #214

Merged
merged 2 commits into from
Dec 17, 2019
Merged

change to release v1.0.0-rc.4 #214

merged 2 commits into from
Dec 17, 2019

Conversation

chusAlvarez
Copy link
Contributor

No description provided.

@chusAlvarez chusAlvarez requested a review from ese as a code owner December 17, 2019 12:12
ese
ese reviewed Dec 17, 2019
View reviewed changes
CHANGELOG.md Outdated
### Changes
- Update kooper to v0.8.0
- Update kubernetes to v1.15.6
- Add support for `hostNetwork` and `dnsPolicy` in Redis and Sentinel pods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great mention here the author

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed :)

ese
ese reviewed Dec 17, 2019
View reviewed changes
CHANGELOG.md Outdated
- Add support for `hostNetwork` and `dnsPolicy` in Redis and Sentinel pods

### Fix
- connect the redis cluster from outside #109 @pmquang
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a fix, it would be a new feature but for me, there is no even feature that specifically does this so i would not include it in the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I added it only because it closed the issue :)

@chusAlvarez chusAlvarez requested a review from ese December 17, 2019 14:36
@chusAlvarez chusAlvarez merged commit 6f100f1 into master Dec 17, 2019
@chusAlvarez chusAlvarez deleted the rc4 branch December 17, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ese ese ese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chusAlvarez @ese