change update strategy #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Nov 18, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
ese
requested changes
Nov 21, 2019
service/redis/client.go
Outdated
| @@ -301,3 +303,18 @@ func (c *client) getConfigParameters(config string) (parameter string, value str | |||
| } | |||
| return s[0], strings.Join(s[1:], " "), nil | |||
| } | |||
|
|
|||
| func (c *client) IsSyncing(ip, password string) (bool, error) { | |||
There was a problem hiding this comment.
I would use a function slaveIsReady for the safety of update process. This can provide a wide overview of the cluster health checking the slaves were are more conditions than syncing state.
- master_host != 127.0.0.1 (pod bootstrap state, needs to be added to the cluster by operator)
- master_link_status:up
- master_sync_in_progress:0
Co-Authored-By: Sergio Ballesteros <[email protected]>
Co-Authored-By: Sergio Ballesteros <[email protected]>
Co-Authored-By: Sergio Ballesteros <[email protected]>
Co-Authored-By: Sergio Ballesteros <[email protected]>
Co-Authored-By: Sergio Ballesteros <[email protected]>
Co-Authored-By: fixmie[bot] <44270338+fixmie[bot]@users.noreply.github.com>
ese
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-This can lead to problems, as the master can be relaunch when the new slave pods are still syncing
-So now the controller takes the update task, killing pod-by-pod and only when the syncing in all slaves is done.